[4.5] Fix FileDialog icon scale in editor#114133
Merged
Merged
Conversation
Member
|
I'd say this should have a co-author for KoBeWi as this is just a back port of that code |
Backport godotengine#114035 Co-authored-by: kobewi <kobewi4e@gmail.com>
2f5f5d9 to
a13e810
Compare
Author
Ah sorry I completely forgot to do that! Patch updated, hope I get it right this time. |
Member
|
The problem is that the template manager uses FileDialog, while everything in editor should be using EditorFileDialog, which doesn't have this problem. |
Author
|
The two failing checks caused by network issue might need to be retriggered manually. |
KoBeWi
approved these changes
Dec 18, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backport #114035
In Godot 4.5.1, on HiDPI screen, the file dialog triggered from "Manage export template" > "Install from file" have the same issue that 144035 attempts to address:
Thus I did this backport: